-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 855 #859
Issue 855 #859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ykumards Please, don't forget to apply black on sources :) I can't commit in your repo to do it.
LGTM :)
Oh, we had a hook for that right? |
Oh maybe during merge because it missed something here. Btw, that's not really important and it was by pure chance that I saw that :) |
@sdesrozis You were right! Black formatting was off, thanks pointing it out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yogesh!
Fixes #855
Description: When warmup_end_value is None, it is set to optimizer initial LR
Check list: